Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Python 3.12 only and CustomComp. Unit testing #947

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Conversation

robbrad
Copy link
Owner

@robbrad robbrad commented Nov 1, 2024

Potential breaking change: We are moving to Python 3.12 only to align to Home Assistant

I have also added unit testing to the Custom Component to add robustness to the sensor.py and config_flow.py

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 88.55721% with 23 lines in your changes missing coverage. Please review.

Project coverage is 94.10%. Comparing base (bd56a38) to head (2167ca0).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
custom_components/uk_bin_collection/sensor.py 88.20% 21 Missing ⚠️
custom_components/uk_bin_collection/config_flow.py 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #947      +/-   ##
==========================================
- Coverage   97.23%   94.10%   -3.14%     
==========================================
  Files           4        8       +4     
  Lines         253      695     +442     
==========================================
+ Hits          246      654     +408     
- Misses          7       41      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robbrad robbrad merged commit 5ba1600 into master Nov 1, 2024
13 of 15 checks passed
@robbrad robbrad deleted the feat/python312 branch November 1, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant